Implement non atomic RateLimiterRedisNonAtomic#345
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Redis-backed non-atomic rate limiter implementation and exposes it as part of the public API.
Changes:
- Introduce
RateLimiterRedisNonAtomicstore implementation and export it from the package entrypoint. - Add TypeScript typings for the new limiter.
- Add an ioredis-based test suite for
RateLimiterRedisNonAtomicand update README + package version.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/RateLimiterRedisNonAtomic.js |
Implements non-atomic upsert logic for Redis clients while preserving TTL behavior. |
index.js |
Exports RateLimiterRedisNonAtomic from the library entrypoint. |
types.d.ts |
Adds TypeScript declaration for RateLimiterRedisNonAtomic. |
test/RateLimiterRedisNonAtomic.ioredis.test.js |
Adds basic ioredis coverage for consume/get/set behaviors. |
README.md |
Updates Redis wiki bullet to mention atomic and non-atomic counters. |
package.json |
Bumps package version to 9.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+10
| this.client = opts.storeClient; | ||
| this._rejectIfRedisNotReady = !!opts.rejectIfRedisNotReady; | ||
| this.useRedisPackage = opts.useRedisPackage || this.client.constructor.name === 'Commander' || false; | ||
| } |
There was a problem hiding this comment.
This implementation has client-specific branches (e.g., useRedisPackage toggling pttl vs pTTL and pexpire vs pExpire), but the PR only adds ioredis tests. Please add a RateLimiterRedisNonAtomic.redis.test.js (node-redis) suite similar to test/RateLimiterRedis.redis.test.js to cover the useRedisPackage: true path and ensure compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.