Passthrough proxy variables to ansible-test environment #84176
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
mkrizek
removed
the
needs_triage
|
@christophert Is there a reason why you want to use environment variables instead of pip config to configure a proxy? |
ansibot
added
the
stale_ci
|
@mattclay The environment variables also apply to the retrieval of the |
|
@mattclay Just checking if there's anything else I could do to push this along? |
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible-test sanitydoes not function within a proxy environment. The environment sanitation for follow-on command execution doesn't carry over any proxy environment variables, which causes pip retrieval and venv environment building to fail.This PR updates the optional environment variables carried over to include any specified proxy vars to the common environment.
Fixes #77304
ISSUE TYPE