Skip to content

Fix code typo in docstring of DataLoader class #85570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Conversation

mcbloch
Copy link
Contributor

@mcbloch mcbloch commented Jul 28, 2025

SUMMARY

Fixed a typo in some example code in the docstring of the DataLoader class.

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jul 28, 2025
@webknjaz
Copy link
Member

@mcbloch could you share how you found it? Were you looking into the source code planning to contribute something more substantial?

@webknjaz
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mcbloch
Copy link
Contributor Author

mcbloch commented Jul 28, 2025

@mcbloch could you share how you found it? Were you looking into the source code planning to contribute something more substantial?

I was trying to figure out how I could interact with Ansible internals to extract stuff like inventory and variables of an Ansible repo to use that in some python script. Was not specifically searching to contribute but this one caught my eye. :)
It does not feel however that I am following any intended workflow. For example reading variables that also contain encrypted parts is a bit hacky due to vault credential loading not being in the API but only in the CLI (if I investigated the source correctly).

@webknjaz
Copy link
Member

@mcbloch you're right. ansible-core doesn't really have an intentional public API short of the CLI. There's ansible-runner that might cover some of these needs, but in general, it's not intended to be imported from Python.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 28, 2025
@Akasurde Akasurde merged commit 340ca1b into ansible:devel Jul 29, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants