Add support for VACUUM in Redshift #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
force-pushed
the
redshift_vacuum
branch
from
719765a to
777d03a
Compare
iffyio
reviewed
Aug 20, 2025
Comment on lines
+10610
to
+10619
| /// '''sql | ||
| /// VACUUM [ FULL | SORT ONLY | DELETE ONLY | REINDEX | RECLUSTER ] [ \[ table_name \] [ TO threshold PERCENT ] \[ BOOST \] ] | ||
| /// ''' |
There was a problem hiding this comment.
Suggested change
| /// '''sql | |
| /// VACUUM [ FULL | SORT ONLY | DELETE ONLY | REINDEX | RECLUSTER ] [ \[ table_name \] [ TO threshold PERCENT ] \[ BOOST \] ] | |
| /// ''' | |
| /// ```sql | |
| /// VACUUM [ FULL | SORT ONLY | DELETE ONLY | REINDEX | RECLUSTER ] [ \[ table_name \] [ TO threshold PERCENT ] \[ BOOST \] ] | |
| /// ``` |
src/parser/mod.rs
Outdated
| @@ -649,6 +649,7 @@ impl<'a> Parser<'a> { | |||
| self.prev_token(); | |||
| self.parse_export_data() | |||
| } | |||
| Keyword::VACUUM => self.parse_vacuum(), | |||
There was a problem hiding this comment.
Suggested change
| Keyword::VACUUM => self.parse_vacuum(), | |
| Keyword::VACUUM => { | |
| self.prev_token(); | |
| self.parse_vacuum() | |
| } |
Thinking so that we can make parse_vacuum standalone to be able to parse a full VACUUM statement
src/parser/mod.rs
Outdated
| let delete_only = self.parse_keywords(&[Keyword::DELETE, Keyword::ONLY]); | ||
| let reindex = self.parse_keyword(Keyword::REINDEX); | ||
| let recluster = self.parse_keyword(Keyword::RECLUSTER); | ||
| let (table_name, threshold, boost) = match self.parse_object_name(false) { |
There was a problem hiding this comment.
Suggested change
| let (table_name, threshold, boost) = match self.parse_object_name(false) { | |
| let (table_name, threshold, boost) = match self.parse_object_name(false)? { |
There was a problem hiding this comment.
Good catch, my intention was to optionally parse an object_name. See latest commit.
yoavcloud
force-pushed
the
redshift_vacuum
branch
from
777d03a to
41af5d4
Compare
iffyio
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.