-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19544. Upgrade to Jackson 2.18.4 #7623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServices is broken by Jackson 2.18 see #7022 (comment) |
08e8bf5
to
743c3c0
Compare
💔 -1 overall
This message was automatically generated. |
743c3c0
to
47641c7
Compare
💔 -1 overall
This message was automatically generated. |
47641c7
to
8f61ff0
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
999c1ea
to
daf0713
Compare
💔 -1 overall
This message was automatically generated. |
If this was rebased, would it be ready to merge? |
@@ -51,6 +53,9 @@ public YarnJacksonJaxbJsonProvider() { | |||
public ObjectMapper locateMapper(Class<?> type, MediaType mediaType) { | |||
ObjectMapper mapper = super.locateMapper(type, mediaType); | |||
configObjectMapper(mapper); | |||
if (type == TimelineAbout.class) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveloughran I needed to add this to fix tests. I'm not sure what has changed in Jackson or other libs that requires this to be set here. Also, I would be concerned that other classes might be affected but that unit tests don't deserialize instances for those classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. not safe for 3.4.2 then
💔 -1 overall
This message was automatically generated. |
Description of PR
HADOOP-19544
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?