XSSF: import chart on drawing #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pjfanning
reviewed
Sep 4, 2018
| * the source chart to be cloned into this drawing. | ||
| * @return the newly created chart. | ||
| * @throws XmlException | ||
| * @throws IOException |
Member
There was a problem hiding this comment.
could you add @since 4.0.0 ? - presuming you want to merge this before we release 4.0.0 (4.0.1 otherwise)
Contributor
Author
|
sorry, I forgot!
fixed!!!
… On 4 Sep 2018, at 11:00, PJ Fanning ***@***.***> wrote:
@pjfanning commented on this pull request.
In src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java <#123 (comment)>:
> public XSSFChart createChart(ClientAnchor anchor) {
- return createChart((XSSFClientAnchor)anchor);
- }
+ return createChart((XSSFClientAnchor) anchor);
+ }
+
+ /**
+ * Imports the chart from the <code>srcChart</code> into this drawing.
+ *
+ * @param srcChart
+ * the source chart to be cloned into this drawing.
+ * @return the newly created chart.
+ * @throws XmlException
+ * @throws IOException
could you add @SInCE 4.0.0 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#123 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdPkJ6hxa2ScOB_W2GhkaYJZ_p1jdM2ks5uXk8igaJpZM4WYHg9>.
|
Contributor
Author
|
merged by r1840076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method originated as a suggestion from [email protected] to copy an existing chart to a new drawing.
https://lists.apache.org/thread.html/9530e875e233ccddf30d2fb505454140966bf8cdfaa26e7bf71a0eaf@%3Cdev.poi.apache.org%3E