feat: Add support for SHEET function #803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry I didn't reopen the other PR and started a new one instead. Won't happen again. |
Member
|
I'll get around to reviewing this in the next few days. |
Member
|
thanks - merged |
Author
|
Thanks for approving and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Excel SHEET function.
Summary of changes:
Implemented org.apache.poi.ss.formula.functions.Sheet as a FreeRefFunction
Correctly resolves:
Motivation:
Currently I get a NotImplementedFunctionException when an Excel file contains the SHEET function and gets processed with POI. Since there is no other way to hook (yet) unsupported functions into poi, I'll need to go over a Pull Request.