Skip to content

Delay initialization of fontRenderContext field & co. by moving it into own inner class #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pjfanning merged 4 commits into from
Sep 30, 2025
Merged

Delay initialization of fontRenderContext field & co. by moving it into own inner class #909

pjfanning merged 4 commits into from
Sep 30, 2025

Conversation

@JaroslavTulach
Copy link
Contributor

@JaroslavTulach JaroslavTulach commented Sep 25, 2025 •
edited
Loading

Excel in Enso

@JaroslavTulach JaroslavTulach mentioned this pull request Sep 25, 2025
Closed
@pjfanning
Copy link
Member

pjfanning commented Sep 25, 2025

Can you rebase due to the code conflict?

@JaroslavTulach JaroslavTulach changed the title Set default value of ignoreMissingFontSystem to true when java.desktop module isn't available Delay initialization of fontRenderContext field & co. by moving it into own inner class Sep 25, 2025
@JaroslavTulach
Copy link
Contributor Author

JaroslavTulach commented Sep 25, 2025 •
edited
Loading

Can you rebase due to the code conflict?

Rebased & conflicts resolved. It was a bit tricky, but I have also gladly found out you changed default value of ignoreMissingFontSystem to true. That's handy!

It seems we are working towards the same goal of being able to run on systems that don't have access to fonts.

pjfanning
pjfanning requested changes Sep 29, 2025
View reviewed changes
@pjfanning pjfanning merged commit 0a17fa9 into apache:trunk Sep 30, 2025
1 check passed
@JaroslavTulach
Copy link
Contributor Author

JaroslavTulach commented Sep 30, 2025

  • Thanks for accepting my change.
  • It will make Enso better - once we upgrade to upcoming version.
    • but we may need few more tweaks...
    • by when do we have to provide them?
  • the history of changes indicates there will be 2025-??-?? release
  • by when do we have to provide our fixes to make it into upcoming release?

@pjfanning
Copy link
Member

pjfanning commented Sep 30, 2025

  • there are no concrete plans for a release
  • it may not even happen in 2025 but it probably will happen later rather than sooner
  • if you want to submit more changes, submit them but I can't guarantee that we will wait for changes before doing a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjfanning pjfanning Awaiting requested review from pjfanning

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaroslavTulach @pjfanning @jtulach