Skip to content

Adds Etsy to OAuth providers #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 13, 2022
Merged

Adds Etsy to OAuth providers #3522

merged 23 commits into from
Aug 13, 2022

Conversation

wess
Copy link
Contributor

@wess wess commented Jul 8, 2022

What does this PR do?

Adds Etsy as an OAuth Provider

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Add application and enable in Etsy

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes

@TorstenDittmann
Copy link
Contributor

@wess linter is failing 👍🏻

wess and others added 2 commits July 21, 2022 09:28
- Reduces scope to only profile and email
- Updates comment for isEmailVerified informing that etsy.com handles verification itself.
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few more comments

@eldadfux eldadfux merged commit 5b4a380 into appwrite:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants