-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Adds Etsy to OAuth providers #3522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wess linter is failing 👍🏻 |
eldadfux
reviewed
Jul 17, 2022
Co-authored-by: Torsten Dittmann <[email protected]>
- Reduces scope to only profile and email - Updates comment for isEmailVerified informing that etsy.com handles verification itself.
christyjacob4
approved these changes
Aug 5, 2022
christyjacob4
requested changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
christyjacob4
requested changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few more comments
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Etsy as an OAuth Provider
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Add application and enable in Etsy
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes