Fixing #3583 - create team membership to return added person name and… #3590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name and email Signed-off-by: Fawzi E. Abdulfattah <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
|
Let me know if you want me to squash the commits |
Meldiron
approved these changes
Jul 28, 2022
|
@christyjacob4, anything else or can this be merged? |
|
@iifawzi great PR, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi, this PR should fix the issue where the info of the person who's creating the membership is returned instead of the person being added information.
Test Plan
I've added two assertions in both
TeamsBaseServerandTeamsBaseClientto ensure that data of the user being added are returned as expected.Related PRs and Issues
#3583
Have you read the Contributing Guidelines on issues?
YES