Fix: User Search attribute (phone) #3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Meldiron, would it make more sense to implement this as filter rather than in so many different places? 🧐 |
2 tasks
We should and can do that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Users have a
searchattribute to support simple and performant search operations. This attribute should include all id, name, email, and phone number.When we implemented phone numbers, we didn't give this enough attention. We now need to include a phone number with each update, and email is no longer required.
This PR makes sure to keep the proper state of this
searchattribute on the user each time a user is updated.Test Plan
No tests were added as it would need interception between AccountAPI and UsersAPI. Let me know if I should add a test anyway.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes