-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Functions Console Logs Capture #3656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @lohanidamodar .
I would also like this to be tested in a concurrent setting as @stnguyen90 mentioned. You can have a simple script to create a series of simultaneously executions.
Within the cloud function you can console.log the current timestamp.
Within the logs, you can then check that no two executions have the same timestamp
@christyjacob4 I will try, however as our runtimes are web server, which should handle concurrent requests already in correct sequence and output is buffered inside the execution not from the docker logs so we should be safe as far s I know. |
@lohanidamodar we can potentially avoid patch releases if we test this scenario well... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. Just need to make final changes to the UI and try and hide the stdout
attribute from the client response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some final changes and then we can merge.
We also need to update the appwrite/runtimes version in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one comment.
What does this PR do?
Test Plan
Related PRs and Issues
(need this released with v2 runtimes tag so we can run CI tests)
Have you read the Contributing Guidelines on issues?
YES