Remove failed attribute #9032
Merged
Remove failed attribute #9032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….x-fix-delete-attribute
Security Scan Results for PRDocker Image Scan Results🎉 No vulnerabilities found! Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
fogelito
commented
Nov 27, 2024
fogelito
commented
Nov 27, 2024
| switch ($attribute->getAttribute('format')) { | ||
| case APP_DATABASE_ATTRIBUTE_INT_RANGE: | ||
| case APP_DATABASE_ATTRIBUTE_FLOAT_RANGE: | ||
| if ($min === $formatOptions['min'] && $max === $formatOptions['max']) { |
There was a problem hiding this comment.
- I removed this for 2 reasons.
- $options is never null , so will always update in the adapter updateAttribute method
- In case of no values changes in $min $max , it will fix the value in _metadata, which currently is overwritten to empty array; having inconsistency between metadata and Appwrite;
abnegate
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To delete failed attributes in _metadata and the adapter.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist