Skip to content

Delete git folder to reduce build size #9076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2024
Merged

Delete git folder to reduce build size #9076

merged 3 commits into from
Dec 11, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Dec 6, 2024 •
edited
Loading

Deletes .git folders within the uploaded files before build

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,028
  • Requests with 200 status code: 185,056
  • P99 latency: 0.177879876

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,028 1,722
200 185,056 309,938
P99 0.177879876 0.069897777

stnguyen90
stnguyen90 reviewed Dec 6, 2024
View reviewed changes
@loks0n loks0n requested a review from stnguyen90 December 10, 2024 10:11
@loks0n loks0n changed the base branch from main to 1.6.x December 10, 2024 13:28
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9076

commit: 1315783

@stnguyen90
Copy link
Contributor

Not sure why tests don't pass. Hopefully rerunning will work

@christyjacob4 christyjacob4 merged commit 3b93b33 into 1.6.x Dec 11, 2024
65 checks passed
@christyjacob4 christyjacob4 deleted the fix-dont-checkout-git-history branch December 11, 2024 15:11
@stnguyen90 stnguyen90 changed the title feat: delete git folder Delete git folder to reduce build size Apr 29, 2025
@stnguyen90 stnguyen90 moved this to Done in 1.6 Release May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.6 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loks0n @stnguyen90 @christyjacob4