Skip to content

Delete attribute No throwing Exception on not found #9157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Delete attribute No throwing Exception on not found #9157

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06a5876
No throwing Exception
fogelito Jan 2, 2025
bd083ac
database 0.53.29
fogelito Jan 2, 2025
e8e39db
Revert lock
fogelito Jan 2, 2025
077313f
Update src/Appwrite/Platform/Workers/Databases.php
abnegate Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
No throwing Exception
  • Loading branch information
@fogelito
fogelito committed Jan 2, 2025
commit 06a5876f35e86b48b4883f26651b27069d6e51e4
5 changes: 3 additions & 2 deletions src/Appwrite/Platform/Workers/Databases.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,9 @@ private function deleteAttribute(Document $database, Document $collection, Docum
$dbForProject->deleteDocument('attributes', $relatedAttribute->getId());
}

throw $e;

/**
* No throwing Exception
*/
} catch (\Throwable $e) {
Console::error($e->getMessage());

Expand Down
Loading