Skip to content

fix: maintenance job missing type #9238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: maintenance job missing type #9238

merged 3 commits into from
Jan 17, 2025

Conversation

christyjacob4
Copy link
Member

What does this PR do?

Set the correct delete type for maintenance jobs

Before
Screenshot 2025-01-17 at 10 54 22 PM

After
Screenshot 2025-01-17 at 10 54 46 PM

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

github-actions bot commented Jan 17, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

✨ Benchmark results

  • Requests per second: 989
  • Requests with 200 status code: 178,093
  • P99 latency: 0.18430375

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 989 1,506
200 178,093 271,082
P99 0.18430375 0.07633957

@christyjacob4 christyjacob4 merged commit d21d18f into 1.6.x Jan 17, 2025
63 checks passed
@christyjacob4 christyjacob4 deleted the fix-maintenance-job branch January 17, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants