This repository was archived by the owner on Mar 3, 2023. It is now read-only.
📝 CONTRIBUTING.md: JavaScript code is linted with Prettier now #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just documents a long-running practice, as of May 2019. For the backstory on the change, see: atom#19391
DeeDeeG
force-pushed
the
docs-js-is-linted-with-prettier-now
branch
from
d376c3a to
68516a1
Compare
DeeDeeG
changed the title
DeeDeeG
changed the title
Contributor
Author
|
CI failure is unrelated. We've been seeing this often on Linux. This has stopped happening for the past few runs of CI at our fork, so maybe it's too early to celebrate, but maybe something we did at our fork can fix this. |
Contributor
|
@DeeDeeG I have also noticed the linux build failure on our CI. I was trying to look at atom-community#88 (comment) but no reference to any pr to fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing Documentation
Description of the Change
The code has been linted with Prettier as of May 2019 (#19391). This obviously means that code conforming to Standard JS style would be flagged as needing changes by our current linter!
Update
CONTRIBUTING.mdto reflect this. (Closes #21132).Release Notes
Docs: JS is linted with Prettier now, not Standard
View rendered CONTRIBUTING.md