Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Use the built-in Visual Studio instead of windows-build-tools v4 #21379

Merged
sadick254 merged 3 commits into from
Apr 29, 2021
Merged

Use the built-in Visual Studio instead of windows-build-tools v4 #21379

sadick254 merged 3 commits into from
Apr 29, 2021

Conversation

@aminya
Copy link
Contributor

@aminya aminya commented Sep 24, 2020 •
edited
Loading

Requires atom/apm#892 -> done

Description of the change

Windows-build-tools v4 (which is an old unmaintained version) installs Visual Studio 2015. But we can use the pre-installed 2017 in vs2017-win2016 Microsoft agents.

Benefits

Using Visual Studio 2017 has many benefits:

  • New compiler produces more optimized binaries and native modules.
  • 2015 is not supported by Microsoft. Its latest version was in 2016 while for Visual Studio 2017 it was in September 8, 2020
  • Windows-build-tools 5 does not work as I have already tested. So, we should move to use the official Visual Studio installations.
  • This will probably solve random Windows build errors that we see here in atom repository. I have not seen them in atom community since we use Visual Studio 2017.
  • This also reduces the CI time by 2-3 min (which is spent on installing windows-build-tools).

Verification

The CI passes. We have been using this for a long time in our community version:
https://github.com/atom-ide-community/atom

Release Notes

  • Use Visual Studio 2017 to build Windows binaries

@aminya
use the pre-installed Visual Studio 2017 instead of windows-build-tools
8dd9901 
Windows-build-tools v4 (which is an old unmaintaind version) installs 
Visual Studio 2015. But we can use the pre-installed 2017 in 
vs2017-win2016

Requires atom/apm#892
@aminya aminya changed the title CI: Use the pre-installed Visual Studio 2017 instead of windows-build-tools CI: Use the Visual Studio 2017 instead of windows-build-tools v4 Sep 24, 2020
@aminya aminya changed the title CI: Use the Visual Studio 2017 instead of windows-build-tools v4 Use the Visual Studio 2017 instead of windows-build-tools v4 Sep 24, 2020
@aminya aminya mentioned this pull request Sep 24, 2020
Merged
@aminya aminya changed the title Use the Visual Studio 2017 instead of windows-build-tools v4 Use the built-in Visual Studio instead of windows-build-tools v4 Apr 28, 2021
@aminya aminya mentioned this pull request Apr 29, 2021
Closed
@sadick254 sadick254 merged commit f87b079 into atom:master Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sadick254 sadick254 sadick254 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aminya @sadick254