Downgrade @babel/core to 7.12.9 (fixes the github package in --dev mode) #21923
Conversation
@babel/core 7.12.10 partly breaks when used with Atom's custom require.resolve() function. That in turn breaks the loading of the "github" package. See atom/github#2620 for details.
DeeDeeG
force-pushed
the
downgrade-babel-core
branch
from
15456b0 to
9fffafc
Compare
|
Changing package-lock.json does not mean anything. You should add an entry to package.json and fix the version there. Anyone can rewrite this change by regenerating the lock file. |
|
@aminya if you want. That would cover more scenarios and be a more durable/thorough fix. (If we do that, whenever a newer release of I understand that you routinely regenerate the lockfiles over at the community fork. This PR's approach is not adequate for that workflow, but it is probably adequate for most other scenarios. |
3 participants
Requirements for Contributing a Bug Fix (from template, click to expand):
Identify the Bug
This PR fixes the
githubpackage for use with Atom's "dev mode".See atom/github#2620 for background info and confirmation from a babel maintainer.
Details
(Brief summary: Atom's custom
require.resolve()function breaks the latest@babel/corerelease's ability to load babel plugins with relative paths (./[path]). This in turn breaks thegithubpackage. We should consider updating our customrequire.resolve()logic, perhaps. But for now, using the previous@babel/corerelease avoids the problem.)(Only the
githubpackage needs@babel/core, so this only affects thegithubpackage. Even then, this fix is only needed for Atom's--devmode, because duringscript/buildthegithubpackage is built with its exact dependencies from itspackage-lock.jsonlockfile. (Thegithubpackage's lockfile uses@babel/core7.3.4). In--devmode, thegithubpackage is loaded from the repository with dependencies listed in the Atom repo's mainpackage-lock.json. So this PR fixesgithubin Atom'sdevmode.)Description of the Change
Downgrade
@babel/coreto the last compatible version for thegithubpackage, 7.12.9.Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
With this change checked out, and doing a quick
apm installto update@babel/corein thenode_modulesfolder, thegithubpackage now loads properly again when loading the repo contents withatom --dev("dev mode").(To reproduce the issue and verify the fix, you may need to delete the compile cache under
~/.atom/compile-cache.)Release Notes
N/A