Add support for passing json values for header and payload#643
Merged
jimmyjames merged 10 commits intoauth0:masterfrom Mar 27, 2023
Merged
Add support for passing json values for header and payload#643jimmyjames merged 10 commits intoauth0:masterfrom
jimmyjames merged 10 commits intoauth0:masterfrom
Conversation
jimmyjames
suggested changes
Mar 15, 2023
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Looks good, thanks! Only request is to not throw the jackson exception, and instead wrap it in an IllegalArgumentException.
| * @return this same Builder instance. | ||
| * @throws JsonProcessingException if json value has invalid structure | ||
| */ | ||
| public Builder withHeader(String headerClaimsJson) throws JsonProcessingException { |
Contributor
There was a problem hiding this comment.
Instead of throwing an exception from jackson, let's catch and throw an IllegalArgumentException with the nested cause, to be consistent with the other methods and not leak the jackson dependency.
| * or if the values are not of a supported type. | ||
| * @throws JsonProcessingException if json value has invalid structure | ||
| */ | ||
| public Builder withPayload(String payloadClaimsJson) throws IllegalArgumentException, JsonProcessingException { |
Contributor
There was a problem hiding this comment.
Same thing here re. the jackson exception.
andrewrigas
requested review from
jimmyjames
and removed request for
jimmyjames
jimmyjames
approved these changes
Mar 27, 2023
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
👍 looks good, thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Relates to #622
Added support for json values to be pass to the
withHeader&withPayloadapis. This should de-couple the library to be only used with java Map and allow easy integration with other languages on JVM.