Fix download a swagger file from given S3 location#444
Merged
sanathkr merged 7 commits intoaws:developfrom May 31, 2018
tendrilinc:fix_load_swagger_s3
Merged
Fix download a swagger file from given S3 location#444sanathkr merged 7 commits intoaws:developfrom tendrilinc:fix_load_swagger_s3
sanathkr merged 7 commits intoaws:developfrom
tendrilinc:fix_load_swagger_s3
Conversation
Signed-off-by: Marcel Casado <mcasado@tendrilinc.com>
mcasado
changed the title
sanathkr
approved these changes
May 31, 2018
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
LGTM
Looks like this is your first time contributing to this repository! Thanks a lot for going through and fixing this bug 🎉.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Casado mcasado@tendrilinc.com
Issue #, if available:
#438
Description of changes:
Uploading swagger files from s3 is broken since we use boto3 method that expected a string and not a file object. Changed to use the right boto3 method that takes the file object. Modified test and added unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.