`using`: Allow looking up `Symbol.dispose` on a function by odinho · Pull Request #16150 · babel/babel

odinho · 2023-12-04T14:19:13Z

This works with browsers and it allows the nice pattern of returning a function that allows you to do something directly with what you used.

I'm just using this to do early 'unpause'-ing of undo functionality.

{
  using unpause = pauseUndo();
  code.doThings();
  if (weAreSomehowDone) unpause();
  code.doOtherThing();
}

It doesn't seem so restrictive in the spec, as a function is also an object, but it has a different typeof name.

babel-bot · 2023-12-04T14:21:26Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55958/

nicolo-ribaudo

Thank you! Yes, this is a bug in our implementation.

I left a minor comment just to make the code slightly smaller. Then, could you:

run make build to re-generate the babel-helpers/src/helpers-generated.ts file
Add a test in packages/babel-plugin-proposal-explicit-resource-management/test/fixtures (look for folders containing exec.js there, and create a new one similar to those)

packages/babel-helpers/src/helpers/using.js

odinho · 2023-12-04T15:29:24Z

@nicolo-ribaudo: Thank you for the very quick review!

I've tried doing what you said ^_^

Added two tests sync/async with slight variations (one wrapped in a call, one just given to using directly).

liuxingbaoyu

Thanks!

nicolo-ribaudo

Thank you!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.23.5` -> `7.23.7`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.5/7.23.7) | --- ### Release Notes <details> <summary>babel/babel (@babel/traverse)</summary> ### [`v7.23.7`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7237-2023-12-29) [Compare Source](babel/babel@v7.23.6...v7.23.7) ##### 🐛 Bug Fix - `babel-traverse` - [#16191](babel/babel#16191) fix: Crash when removing without `Program` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16180](babel/babel#16180) fix: Class decorator `ctx.kind` is wrong ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-plugin-proposal-decorators` - [#16170](babel/babel#16170) Fix decorator initProto usage in derived classes ([@JLHwung](https://github.com/JLHwung)) - `babel-core` - [#16167](babel/babel#16167) Avoid unpreventable `unhandledRejection` events ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-helper-create-class-features-plugin` - [#16186](babel/babel#16186) chore: Update deps ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16177](babel/babel#16177) Merge decorators into class features ([@JLHwung](https://github.com/JLHwung)) ### [`v7.23.6`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7236-2023-12-11) [Compare Source](babel/babel@v7.23.5...v7.23.6) ##### 👓 Spec Compliance - `babel-generator`, `babel-parser`, `babel-types` - [#16154](babel/babel#16154) Remove `TSPropertySignature.initializer` ([@fisker](https://github.com/fisker)) - `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime`, `babel-types` - [#16139](babel/babel#16139) Apply `toPropertyKey` on decorator context name ([@JLHwung](https://github.com/JLHwung)) ##### 🐛 Bug Fix - `babel-generator` - [#16166](babel/babel#16166) fix: Correctly indenting when `retainLines` is enabled ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-explicit-resource-management` - [#16150](babel/babel#16150) `using`: Allow looking up `Symbol.dispose` on a function ([@odinho](https://github.com/odinho)) - `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#16161](babel/babel#16161) Ensure the `[[@@toPrimitive]]` call of a decorated class member key is invoked once ([@JLHwung](https://github.com/JLHwung)) - [#16148](babel/babel#16148) Support named evaluation for decorated anonymous class exp ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-transform-for-of`, `babel-preset-env` - [#16011](babel/babel#16011) fix: `for of` with `iterableIsArray` and shadowing variable ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16144](babel/babel#16144) Set function name for decorated private non-field elements ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-transform-typescript` - [#16137](babel/babel#16137) Fix references to enum values with merging ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🔬 Output optimization - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-class-properties` - [#16159](babel/babel#16159) Reuse computed key memoiser ([@JLHwung](https://github.com/JLHwung)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16160](babel/babel#16160) Optimize decorator helper size ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/129 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

**Related issue:** - Closes #8570 - babel/babel#16150

nicolo-ribaudo reviewed Dec 4, 2023

View reviewed changes

packages/babel-helpers/src/helpers/using.js Outdated Show resolved Hide resolved

nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Explicit Resource Management labels Dec 4, 2023

using: Allow looking up 'Symbol.dispose' on a function

94c3bf4

liuxingbaoyu approved these changes Dec 5, 2023

View reviewed changes

nicolo-ribaudo approved these changes Dec 11, 2023

View reviewed changes

nicolo-ribaudo changed the title ~~using: Allow looking up 'Symbol.dispose' on a function~~ using: Allow looking up Symbol.dispose on a function Dec 11, 2023

nicolo-ribaudo merged commit ed365d1 into babel:main Dec 11, 2023

odinho deleted the patch-1 branch December 13, 2023 15:14

Austaras mentioned this pull request Jan 30, 2024

Support the using keyword for functions swc-project/swc#8570

Closed

kdy1 added a commit to kdy1/swc that referenced this pull request Jan 30, 2024

https://github.com/babel/babel/pull/16150

8083491

kdy1 mentioned this pull request Jan 30, 2024

fix(es/proposals): Support using using keyword with functions swc-project/swc#8574

Merged

kdy1 added a commit to swc-project/swc that referenced this pull request Jan 30, 2024

fix(es/proposals): Support using using keyword with functions (#8574)

d81596c

**Related issue:** - Closes #8570 - babel/babel#16150

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 14, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`using`: Allow looking up `Symbol.dispose` on a function#16150

`using`: Allow looking up `Symbol.dispose` on a function#16150
nicolo-ribaudo merged 1 commit intobabel:mainfrom
odinho:patch-1

odinho commented Dec 4, 2023 •

edited

Loading

Uh oh!

babel-bot commented Dec 4, 2023 •

edited

Loading

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

Uh oh!

odinho commented Dec 4, 2023

Uh oh!

liuxingbaoyu left a comment

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

odinho commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

odinho commented Dec 4, 2023

Uh oh!

liuxingbaoyu left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

odinho commented Dec 4, 2023 •

edited

Loading

babel-bot commented Dec 4, 2023 •

edited

Loading