Fix language selection #3713
Merged
Fix language selection #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
blckmn
reviewed
Dec 31, 2023
src/js/tabs/landing.js
Outdated
| @@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
| bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
| }); | |||
|
|
|||
| bottomSection.find('a').each((index) => { | |||
| bottomSection.find('a').each(function(index) { | |||
There was a problem hiding this comment.
Suggested change
| bottomSection.find('a').each(function(index) { | |
| bottomSection.find('a').each((index, element) => { |
blckmn
reviewed
Dec 31, 2023
src/js/tabs/landing.js
Outdated
| @@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
| bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
| }); | |||
|
|
|||
| bottomSection.find('a').each((index) => { | |||
| bottomSection.find('a').each(function(index) { | |||
| let element = $(this); | |||
There was a problem hiding this comment.
Suggested change
| let element = $(this); |
There was a problem hiding this comment.
Both suggestions did not work :(
Arrow functions and this don't get along
Reverted and it works again
haslinghuis
force-pushed
the
fix-language-option
branch
2 times, most recently
from
b20d30e to
91521c0
Compare
This comment has been minimized.
This comment has been minimized.
blckmn
reviewed
Dec 31, 2023
src/js/tabs/landing.js
Outdated
| @@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
| bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
| }); | |||
|
|
|||
| bottomSection.find('a').each((index) => { | |||
| bottomSection.find('a').each(function(index) { | |||
| let element = $(this); | |||
| element.click(() => { | |||
There was a problem hiding this comment.
Suggested change
| element.click(() => { | |
| $(element).click(() => { |
Also need to change this (if passing the param).
|
This one is ok, can change language. |
haslinghuis
force-pushed
the
fix-language-option
branch
from
91521c0 to
64a1c95
Compare
haslinghuis
force-pushed
the
fix-language-option
branch
from
64a1c95 to
1ebed15
Compare
|
|
Do you want to test this code? Here you have an automated build: |
blckmn
approved these changes
Jan 1, 2024
chmelevskij
pushed a commit
to chmelevskij/betaflight-configurator
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.