Skip to content

Conversation

@okrc
Copy link
Contributor

@okrc okrc commented Dec 5, 2025

{
  preferred_chains {
    root_common_name "Example root name"
    root_common_name "Example root name 2"
  }
}

I mainly noticed that when I write multiple lines for root_common_name, the last line always overrides the previous ones, and there is no warning or indication that this is not allowed. I attempted to modify it so that multiple lines can be used. Thank you for all your work on this project.

Assistance Disclosure

No AI was used.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2025

CLA assistant check
All committers have signed the CLA.

@francislavoie
Copy link
Member

That's fine I guess, typically we throw an error if trying to fill an already-filled value, sometimes we allow repeated values. In this case I think you could've put all the values in sequence on one line. But I can see the argument for allowing it on multiple lines too.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Dec 7, 2025
@francislavoie francislavoie enabled auto-merge (squash) December 7, 2025 16:13
@francislavoie francislavoie added this to the v2.11.0 milestone Dec 7, 2025
@francislavoie francislavoie merged commit 374b7a6 into caddyserver:master Dec 7, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Jan 6, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants