lxd: Improve certificate add token validation #13749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inTokenValid Signed-off-by: Thomas Parrott <[email protected]>
markylaing
requested changes
Jul 12, 2024
Contributor
markylaing
left a comment
markylaing
left a comment
There was a problem hiding this comment.
LGTM just a couple of comments to update :)
tomponline
force-pushed
the
tp-token-expiry
branch
from
c5c0bdc to
b6ac0d4
Compare
tomponline
force-pushed
the
tp-token-expiry
branch
from
b6ac0d4 to
6f15862
Compare
- An expired token could be used if operation was non-local due to missing validation & conversion. - Use happy path code style. - Explicitly check operation's location in order to decide unmarshalling format of `request` field rather than rely on errors - allows for better validation. Signed-off-by: Thomas Parrott <[email protected]>
…ion in test_clustering_trust_add Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-token-expiry
branch
from
6f15862 to
10c8639
Compare
markylaing
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a certificate add token stored in an operation on a non-local cluster member the expiry time of the token wasn't being taken into account due to incorrect data type conversion and error checking.