-
Notifications
You must be signed in to change notification settings - Fork 985
Live migration with attached storage volumes (from Incus) #13823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tomponline
merged 6 commits into
canonical:main
from
markylaing:live-migration-attached-volumes
Jul 30, 2024
Merged
Live migration with attached storage volumes (from Incus) #13823
tomponline
merged 6 commits into
canonical:main
from
markylaing:live-migration-attached-volumes
Jul 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Jul 29, 2024
b053449 to
250f6a8
Compare
tomponline
reviewed
Jul 30, 2024
tomponline
reviewed
Jul 30, 2024
tomponline
reviewed
Jul 30, 2024
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit e134d99072870259ea7727e1eb8b2b70cafdfed4) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 356c6842d99b31a4da6083287ae579fe3b73bc64) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 72a06a4f33a0a693533f4a5799b4e1c1029501ab) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 6499313e75f4539123be2a9b8cead15022ea6140) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
250f6a8 to
cc5beab
Compare
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 67777f96337938374fbc208d9fa9beed5e227346) Signed-off-by: Mark Laing <[email protected]> License: Apache-2.0
Signed-off-by: Mark Laing <[email protected]>
cc5beab to
7e8d784
Compare
Contributor
Author
|
I've addressed the comments and the test (canonical/lxd-ci#250) is passing for me locally. It is also failing at the expected point in github actions, so I believe it will pass once this is merged and in latest/edge. |
tomponline
approved these changes
Jul 30, 2024
tomponline
added a commit
to canonical/lxd-ci
that referenced
this pull request
Jul 31, 2024
This will fail until canonical/lxd#13823 is merged.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables live-migration of an instance with volumes attached as long as those disks are also on a remote storage pool.
Created as draft while I finish writing tests.
Closes #12694