lxd: Prevent conversion from OVA file format #13877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OVA (Open Virtualization Appliance) file is not a virtual disk format like VMDK and QCOW2. Instead, it is an archive format used for distributing virtual appliances. Since qemu-img info detects it as raw image format, we cannot use that to detect OVA files. Instead we need to check whether the uploaded file is a tar archive (contains a tar header). Note that we need to reset the file's read pointer after the file is uploaded and also open file with read permission (in addition to already requested write permission). Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/conversion-ova
branch
from
98f4798 to
5befe3d
Compare
tomponline
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents conversion from OVA file format. On the server side we check whether the file is a tarball when the file is uploaded.
To prevent file from being uploaded in the first place, we also use the same check in
lxd-migrate.