-
Notifications
You must be signed in to change notification settings - Fork 985
Documentation: VM live migration internals documentation #14574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: VM live migration internals documentation #14574
Conversation
7097b26 to
ebfb411
Compare
lxd/instance/drivers/docs/vm-live-migration-developer-documentation.md
Outdated
Show resolved
Hide resolved
ebfb411 to
b267ee6
Compare
00ecdc6 to
3399871
Compare
|
@tomponline any additional sections you'd like to see here before I request reviews, or perhaps more detail in a particular section? |
6f81d29 to
b1f6cb8
Compare
|
The tests should pass once #14600 is merged. |
As I mentioned in that PR, the fix implemented there causes other issues. I assume this is the test failure you're wanting to fix:
where you want to direct to the Ubuntu discourse article and not a LinuxContainers one. That should be fixed by using the in line 2 of Furthermore, to make sure that we don't rely on fetching the page title at build, which can cause the build to fail if the Ubuntu Discourse is down, add the title statically. The related-links extension we use requires replacing spaces in the title with |
|
Per conversation with @kadinsayani, I understand that the intent of #14600 is to update the discourse links so that the Ubuntu one is the default (and eventually only) discourse used for related links. If it is merged as the default, you wouldn't need to use However, you'd at least want to use the static title, for the build failure reasons I mentioned: If we aren't migrating all the lxc links to ubuntu at this time/not switching the default discourse, then you will need to specify |
b1f6cb8 to
6c87be3
Compare
9c50463 to
54c1042
Compare
54c1042 to
45be09d
Compare
|
Thanks for all your feedback @simondeziel! I'm going to reword the steps to make things more clear. |
62915dd to
586bc7c
Compare
ce55e0b to
dd603d5
Compare
dd603d5 to
fa0ff72
Compare
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
fa0ff72 to
2b77167
Compare
tomponline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Resolves #13307
This PR adds developer documentation outlining the VM live migration process.