Introduce source type constants #14587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
… constant Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/constants
branch
from
27294cd to
55058a0
Compare
Signed-off-by: Din Music <[email protected]>
…h a variable Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/constants
branch
from
55058a0 to
f33ea82
Compare
tomponline
reviewed
Dec 6, 2024
| // Handle errors | ||
| if response.Type == api.ErrorResponse { | ||
| return nil, "", api.StatusErrorf(resp.StatusCode, response.Error) | ||
| return nil, "", api.StatusErrorf(resp.StatusCode, "%s", response.Error) |
Member
There was a problem hiding this comment.
@markylaing added api.NewStatusError for this scenario to avoid needing the parsing cost of fmt.Errorf
tomponline
added a commit
that referenced
this pull request
Dec 6, 2024
Addresses comment #14587 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded strings for container/instance source type.
Also fixed some issue reported by static analysis.