Skip to content

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Mar 1, 2025

The github.com/moby/sys/capability package is a fork of the original one, which is apparently no longer maintained.

For changes since the fork took place, see
https://github.com/moby/sys/blob/main/capability/CHANGELOG.md

(The indirect dependency still remains because of runtime-tools; this is being fixed in
opencontainers/runtime-tools#777).

Related to: moby/sys#183

@tomponline
Copy link
Member

@kolyshkin hi, thanks for this.

Are you able to sign the Canonical CLA? https://ubuntu.com/legal/contributors

If not then we could land this change on your behalf.

@tomponline
Copy link
Member

@mihalicyn would you mind taking this one over please?

@kolyshkin
Copy link
Contributor Author

Signed the CLA, rebased the PR.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mihalicyn
Copy link
Contributor

LGTM.

Thanks for submitting this change, Kir!

@tomponline
Copy link
Member

@kolyshkin please can you sign your commits too

@kolyshkin
Copy link
Contributor Author

@kolyshkin please can you sign your commits too

@tomponline could you please clarify this? My patch always had Signed-off-by: line. If you mean something else (like a GPG signature), please let me know.

@tomponline
Copy link
Member

Thanks. Yes they are signed off (for DCO) but need to also be signed.

You can use either SSH or GPG, see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

The github.com/moby/sys/capability package is a fork of the original
one, which is apparently no longer maintained.

For changes since the fork took place, see
https://github.com/moby/sys/blob/main/capability/CHANGELOG.md

(The indirect dependency still remains because of runtime-tools;
this is being fixed in
opencontainers/runtime-tools#777).

Signed-off-by: Kir Kolyshkin <[email protected]>
GPG signed by Alexander Mikhalitsyn
Signed-off-by: Alexander Mikhalitsyn <[email protected]>
@mihalicyn
Copy link
Contributor

I have added my GPG signature.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit 1a14cfe into canonical:main Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants