lxd/storage/drivers/pure: Unmap volume when connection is freshly created #15211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated Signed-off-by: Din Music <[email protected]>
Member
Author
|
Tests are still running, will mark it as ready once all tests pass. |
Contributor
|
Checked the corresponding section in PowerFlex, looks to be not affected. |
Member
Author
|
Thanks for confirmation. I've checked it as well and only PureStorage is affected. |
tomponline
added a commit
to canonical/lxd-pkg-snap
that referenced
this pull request
Mar 19, 2025
Fixes from: - canonical/lxd#15213 - canonical/lxd#15207 - canonical/lxd#15211 - canonical/lxd#15198 - Revert of canonical/lxd@cd89668 (loki connection failure preventing LXD start up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes left-over volumes on the PureStorage array when volume creation fails.
The
unmapVolumemust be added toouterReverterwhen we are the first to associate (connect) the volume with the PureStorage host. The comment above is correct, just the condition was wrong.Fixes #15210