Skip to content

Conversation

@kadinsayani
Copy link
Member

Cherry-picked from lxc/incus#567.

@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 3 times, most recently from 004423b to f72138b Compare May 15, 2025 13:29
@kadinsayani kadinsayani changed the title Update context (from Incus) wip: Update context (from Incus) May 18, 2025
simondeziel
simondeziel previously approved these changes May 19, 2025
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being very familiar with the concept of contexts, I won't review the code itself. The cherry-picked commits all have proper attribution and license tag so I'll ACK that part.

@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 4 times, most recently from 6c87b01 to 8459ba0 Compare May 23, 2025 20:51
@kadinsayani kadinsayani changed the title wip: Update context (from Incus) Update context (from Incus) May 23, 2025
@kadinsayani kadinsayani requested a review from markylaing May 23, 2025 20:52
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 2 times, most recently from 0c78796 to 99f2878 Compare May 23, 2025 21:09
@kadinsayani kadinsayani marked this pull request as ready for review May 23, 2025 21:09
@kadinsayani kadinsayani marked this pull request as draft May 23, 2025 21:17
@kadinsayani kadinsayani changed the title Update context (from Incus) WIP: Update context (from Incus) May 23, 2025
@kadinsayani kadinsayani changed the title WIP: Update context (from Incus) [WIP] Update context (from Incus) May 27, 2025
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch from 99f2878 to 16626d1 Compare June 6, 2025 21:05
@kadinsayani kadinsayani marked this pull request as ready for review June 6, 2025 21:53
@kadinsayani kadinsayani changed the title [WIP] Update context (from Incus) Update context (from Incus) Jun 6, 2025
@kadinsayani kadinsayani requested a review from MusicDin June 6, 2025 21:54
@tomponline
Copy link
Member

@kadinsayani ready for rebase

@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 3 times, most recently from 553fde3 to ce6143b Compare June 9, 2025 14:59
Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looking good. I think only the change in LocateImage is causing context deadline issues

@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch from ce6143b to e6f0323 Compare June 9, 2025 15:28
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch from e6f0323 to db06a3f Compare June 9, 2025 15:52
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 8df72db5aee7bc6c322051db1fba211c79b75fd0)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 6 times, most recently from 2efd77a to cb95765 Compare June 9, 2025 21:40
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit fe7742d0ce26e72d2f965d9cbb9054d3a8c84ad6)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 000ab543a5ef5799fd4d316624709e15ac384bc9)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch 2 times, most recently from 8d337fe to 7f5652c Compare June 9, 2025 22:13
monstermunchkin and others added 9 commits June 9, 2025 16:17
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit d2acfcd31428d1c3fa06734d983ce373980e51f7)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit aea11ec150a54b96ceefe5d70184e4f10b723e3e)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit a5201eed43b6996d456e2b65c2acab6208516305)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 9d0d06cdd535fdb1cc02c65e5b6ca6f6fa25f97e)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit fd5fde7cb8ae9ee3e12e109c1e5588c6dddcc035)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 01da4f413baa5c9b567e47a325cc9b7d2cc6ed94)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 3be19c71862b82ed319fe28a2845c98035eb07ef)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Kadin Sayani <[email protected]>
…teMigrateFunc` function type

Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani kadinsayani force-pushed the incus-cherry-picks/update-context branch from 7f5652c to 38fcb55 Compare June 9, 2025 22:18
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline
Copy link
Member

@kadinsayani please update the import spreadsheet. Ta

@tomponline tomponline merged commit d785878 into canonical:main Jun 11, 2025
30 checks passed
@kadinsayani kadinsayani deleted the incus-cherry-picks/update-context branch June 11, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants