-
Notifications
You must be signed in to change notification settings - Fork 985
github: add golangci-lint action #15720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a402632 to
34f6b87
Compare
tomponline
reviewed
Jun 4, 2025
b5caf1b to
1ecfb83
Compare
tomponline
reviewed
Jun 5, 2025
Member
|
Please rebase |
Note: the action supports a [`only-new-issues`](https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#only-new-issues) argument but this operates on patch/diff but we want the `--whole-files` option to be effective. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
1ecfb83 to
b3c3ce4
Compare
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
b3c3ce4 to
746554b
Compare
tomponline
approved these changes
Jun 6, 2025
Member
tomponline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This GH action provides faster checks thanks mainly to using action/cache as explained here. The cached assets are very small (1.3MiB for this run).
Here faster means ~55s down to ~20s which is important as the
Codestep is blocking everything else.