Skip to content

Conversation

@simondeziel
Copy link
Member

@simondeziel simondeziel commented Jun 4, 2025

This GH action provides faster checks thanks mainly to using action/cache as explained here. The cached assets are very small (1.3MiB for this run).

Here faster means ~55s down to ~20s which is important as the Code step is blocking everything else.

@simondeziel simondeziel force-pushed the golangci-lint-action branch from a402632 to 34f6b87 Compare June 4, 2025 19:54
@simondeziel simondeziel marked this pull request as ready for review June 4, 2025 20:12
@simondeziel simondeziel marked this pull request as draft June 4, 2025 20:55
@simondeziel simondeziel force-pushed the golangci-lint-action branch from b5caf1b to 1ecfb83 Compare June 4, 2025 21:36
@simondeziel simondeziel marked this pull request as ready for review June 4, 2025 22:09
@tomponline
Copy link
Member

Please rebase

Note: the action supports a [`only-new-issues`](https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#only-new-issues)
argument but this operates on patch/diff but we want the `--whole-files` option
to be effective.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel simondeziel force-pushed the golangci-lint-action branch from 1ecfb83 to b3c3ce4 Compare June 5, 2025 16:59
@simondeziel simondeziel force-pushed the golangci-lint-action branch from b3c3ce4 to 746554b Compare June 5, 2025 17:01
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit b15fafa into canonical:main Jun 6, 2025
30 checks passed
@simondeziel simondeziel deleted the golangci-lint-action branch June 6, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants