lxd/db: Rework RunExclusive to use context with timeout internally #15743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid a potential race where the go routine takes the mutex and tries to send the acquired message to the outer function before it is waiting on the channel and then incorrectly detects this as the outer function having returned, which then results in the outer function waiting until the 20s timeout and returning an error. Signed-off-by: Thomas Parrott <[email protected]>
tomponline
changed the title
simondeziel
approved these changes
Jun 8, 2025
Member
|
You probably know but just in case, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid a potential race where the go routine takes the mutex and tries to send the acquired message to the outer function before it is waiting on the channel and then incorrectly detects this as the outer function having returned, which then results in the outer function waiting until the 20s timeout and returning an error.
Fixes issue introduced by #15726