Various auth improvements #16256
Merged
Various auth improvements #16256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response writer is not referenced in the block, so there is no need for the nil check. Signed-off-by: Mark Laing <[email protected]>
We rely on the authorizer to check if the identity is in the cache during each access check. We will soon stop doing this and instead add the identity to the request context. So we need to restrict this further so that PKI is only set when `core.trust_ca_certificates` is true, the client certificate is signed by the CA, and the certificate is not present in the identity cache. Signed-off-by: Mark Laing <[email protected]>
This was starting a transaction unnecessarily if the request was not a cluster notification. Signed-off-by: Mark Laing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were also part of #16223 but can be merged separately to ease it's review. This will need to be rebased when #16255 is merged.