lxd-benchmark: improve test coverage #16258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
extend-benchmark-coverage
branch
from
d7d6bc5 to
75edf39
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves test coverage for the lxd-benchmark tool by adding new test scenarios and removing unused code. The changes enhance validation of error conditions and expand testing of various benchmark commands.
Key changes:
- Adds test for error handling when launching with non-existent images
- Expands test coverage with additional benchmark command variations (freeze, privileged, start)
- Removes unused
CreateContainersfunction from benchmark package
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/suites/lxd-benchmark.sh | Adds error condition test and new benchmark command variations, updates expected report line count |
| lxd-benchmark/benchmark/benchmark.go | Removes unused CreateContainers function to clean up dead code |
Member
Author
|
The test runtime difference is not even measurable on the slowest driver ( |
tomponline
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.