Open
Conversation
dmitry-lyfar
force-pushed
the
feature/amd-cdi-job
branch
from
d4458a3 to
32f2259
Compare
simondeziel
added a commit
to simondeziel/lxd-ci
that referenced
this pull request
Jan 15, 2026
This should pave the way to integrate some AMD tests (canonical#654) Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
reviewed
Jan 15, 2026
Member
simondeziel
left a comment
simondeziel
left a comment
There was a problem hiding this comment.
This PR looks good to me however I think it'd be best to put it in the same workflow as the other GPU passthrough one.
To that effect, I've proposed renaming the NVIDIA one to be more generic, see #658
dmitry-lyfar
force-pushed
the
feature/amd-cdi-job
branch
from
32f2259 to
f5c9ba3
Compare
Author
Sounds good, thanks. I've rebased and fixed the paths listed for the pull request trigger -- there was the old filename. |
simondeziel
reviewed
Jan 28, 2026
Member
simondeziel
left a comment
simondeziel
left a comment
There was a problem hiding this comment.
LGTM with the tiny nit about exclude.
Signed-off-by: Dmitry Lyfar <dmitry.lyfar@canonical.com>
dmitry-lyfar
force-pushed
the
feature/amd-cdi-job
branch
from
f5c9ba3 to
b186df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.