Invoke virt-v2v-in-place on host#510
Merged
tomponline merged 2 commits intocanonical:latest-edgefrom Jul 25, 2024
Merged
Conversation
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
tomponline
approved these changes
Jul 25, 2024
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Jul 26, 2024
This PR adds new conversion option `virtio` (disabled by default). When enabled, LXD invokes `virt-v2v-in-place` tool on the host to inject virtio drivers into the image. For Windows images, additional drivers need to be present in `/usr/share/virt-tools`. This requires: - For rebase: #13385 - Custom command in LXD snap to invoke virt-v2v-in-place on the host: canonical/lxd-pkg-snap#510
Member
|
It's a bit late now (I was in vacation) but could we have used the existing |
Member
|
If we can use run-host that would be useful. |
tomponline
added a commit
that referenced
this pull request
Aug 29, 2024
From #510 This is required for conversion option `virtio` which failed the tests for 5.21-edge in canonical/lxd-ci#274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for virt-v2v-in-place to be invoked on the host.
Requires: canonical/lxd#13748