Skip to content

Produce less String-related garbage in ReflectUtils::getClass #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stsypanov wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −6
Open

Produce less String-related garbage in ReflectUtils::getClass #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Produce less String-related garbage in ReflectUtils::getClass
  • Loading branch information
@SergiiTsypanov
SergiiTsypanov committed Jul 8, 2019
commit 4506fc8469d0881b83703e9829a1a9ffe65a230a
18 changes: 12 additions & 6 deletions cglib/src/main/java/net/sf/cglib/core/ReflectUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,7 @@ private static Class getClass(String className, ClassLoader loader, String[] pac
while ((index = className.indexOf("[]", index) + 1) > 0) {
dimensions++;
}
StringBuffer brackets = new StringBuffer(className.length() - dimensions);
for (int i = 0; i < dimensions; i++) {
brackets.append('[');
}
String brackets = getBrackets(dimensions);
className = className.substring(0, className.length() - 2 * dimensions);

String prefix = (dimensions > 0) ? brackets + "L" : "";
Expand Down Expand Up @@ -271,8 +268,17 @@ private static Class getClass(String className, ClassLoader loader, String[] pac
}
throw new ClassNotFoundException(save);
}



private static String getBrackets(int dimensions) {
if (dimensions == 0) {
return "";
}
char[] brackets = new char[dimensions];
Arrays.fill(brackets, '[');
return new String(brackets);
}


public static Object newInstance(Class type) {
return newInstance(type, Constants.EMPTY_CLASS_ARRAY, null);
}
Expand Down