Fix: gh pr create --web does not respect title and body arguments #10533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: S1NJED <[email protected]>
Signed-off-by: S1NJED <[email protected]>
Signed-off-by: S1NJED <[email protected]>
Signed-off-by: S1NJED <[email protected]>
cliAutomation
added
the
external
|
👋 @S1NJED I discussed this situation regarding there being more than one PR open with the core team, and we decided to opt for the other PR #10547 since it's closer to a state that we would accept, with it having unit tests written. We appreciate you working to improve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10527
Solution
I added a condition if
opts.TitleProvidedandopts.BodyProvidedthen add the title and body.I also noticed that using this command:
gh pr create --assignee @me --fill --title "test" --body "ticket number" --webgive the expected behaviour but when omitting the --assignee option it does not.