Fix lockup involving specific mount order #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnovak
reviewed
Mar 5, 2023
johnnovak
reviewed
Mar 5, 2023
johnnovak
reviewed
Mar 5, 2023
johnnovak
approved these changes
Mar 5, 2023
kcgen
force-pushed
the
kc/dev-loop-1
branch
2 times, most recently
from
a8868bf to
40c4e53
Compare
|
Thanks for the detailed review @johnnovak - much improved. |
4 tasks
3 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2304, which reports that Staging locks up when a floppy image is mounted before a CDROM image, followed by accessing the mounted floppy drive.
This lockup is caused by the device scanning routine added in 598de87, which enters and endless loop.
This PR adds some basic routines to walk and query the DOS device linked list, and uses them in function to replace the one that locks up.
To prove that we can trust the replacement function, an intermediate commit compares its results against the original function'd results using asserts (which indeed pass in all of the tests I've thrown at it, including scanning the win 3.11 device drivers).
Finally the PR pivots to use the replacement function, along with making use of the new functions in the MSCDEX code.
Thanks to @distantvale for catching this.