Awesome overhaul and function improvement.

• De-Bitu
• #define constants to constexpr; now we can see variables in debuggers and not literals
• #define functions to lamdas: now we can get valid backtraces

The functional chunks of code are made more readable.

@GranMinigun "Sanitizers seem to be happy here"

👍

Scaling perfectly to various DPIs on Linux and macOS:

@GranMinigun @kcgen Ok, that merging was a bit premature, so it seems.

I can open the mapper fine on macOS and the coordinate mappings work fine, so it's fully functional. But the Exit button does not hide it, so once opened, I'm stuck with it.

Shall I create a regression ticket for this @GranMinigun or are looking into it? This broke the mapper in main at least on macOS.

I'm not sure how you're unable to exit from the mapper. Definitely cannot reproduce here. No need for a separate ticket, it can be discussed here.

I'm not sure how you're unable to exit from the mapper. Definitely cannot reproduce here. No need for a separate ticket, it can be discussed here.

In OpenGL output modes if I click on Exit, the mapper never disappears. That's it, plain and simple! 😄 Switching to fullscreen then back to windowed doesn't fix it, changing the window size doesn't fix it, nothing fixes it. The mapper screen never disappears, and the Exit button stays higlighted:

The emulator keeps working though. So I'm a sneaky bastard and I'm typing output = texture in the console, completely blind, then lo and behold:

So somehow the Exit button press never triggers the "hide mapper" event or something.

If I use output = texture, it works fine; Exit closes the mapper.

@GranMinigun Works fine on Windows 10 🥶 SDL... 😐

This is a bit of a problem because you don't have a Mac... I guess it will be @kklobe, @kcgen or myself who fixes it.

Any suggestions are welcome. I've done some quick tracing, and render_reset() does get callled after exiting the mapper. Just that Rube Goldberg machine from hell that is sdlmain pokes SDL slightly the wrong way on macOS... I guess... Or maybe it pokes it the same way on all three platforms, but macOS needs a bit of "special poking". 😅 Sheeeet.

Sorry for merging too soon. Been offline, but will check it out tomorrow and see what you think, @GranMinigun.

Two things to check: whether other renderer backends work (e.g. texture_renderer=opengl and others); and whether context variable gets populated properly and is still valid by the time it is made current.

Two things to check: whether other renderer backends work (e.g. texture_renderer=opengl and others)

That's it @GranMinigun; results from macos:

This exits the mapper properly:

output = opengl
texture_renderer = opengl

These also exit properly:

output = texture
texture_renderer = (all: metal, software, opengles2, opengl)

However these don't:

output = opengl
texture_renderer = metal, opengles2, or software

The context is always getting populated.

Alright, I see software renderer outright crashes on my side. Will think about what to do and raise a follow-up PR.