Skip to content

Only process MT-32 debug messages in debug builds #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Nov 7, 2023

Description

Skips processing MT-32 debug messages in release builds because it can be excessive:

2023-11-06_20-23

Also changes the logic slightly to let Loguru process the variable list directly, which fixes #3096.

Related issues

Fixes #3096, both in release and debug builds.

Manual testing

Tested MT-32 in release, debug, and sanitizer builds.

Checklist

I have:

  • followed the project's contributing guidelines and code of conduct.
  • performed a self-review of my code.
  • commented on the particularly hard-to-understand areas of my code.
  • split my work into well-defined, bisectable commits, and I named my commits well.
  • applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
  • checked that all my commits can be built.
  • confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
  • added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
  • made corresponding changes to the documentation or the website according to the documentation guidelines.
  • locally verified my website or documentation changes.

@kcgen kcgen added bug Something isn't working audio Audio related issues or enhancements labels Nov 7, 2023
@kcgen kcgen requested a review from johnnovak November 7, 2023 04:37
@kcgen kcgen self-assigned this Nov 7, 2023
@kcgen kcgen force-pushed the kc/mt32-selective-debug-1 branch from f8847c3 to 2c743fa Compare November 7, 2023 04:38
@kcgen kcgen force-pushed the kc/mt32-selective-debug-1 branch from 2c743fa to 8b1b0e1 Compare November 7, 2023 04:39
Copy link
Member

@johnnovak johnnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @kcgen

@kcgen kcgen merged commit 717c255 into main Nov 7, 2023
@kcgen kcgen deleted the kc/mt32-selective-debug-1 branch November 7, 2023 16:41
@johnnovak johnnovak added the midi MIDI related features and issues label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Audio related issues or enhancements bug Something isn't working midi MIDI related features and issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ghost Busters II w/ MT-32 crashes Dosbox
2 participants