Description

Before this change, raw image and video captures of the 160x200 16-colour Tandy/PCjr video modes were written width-doubled as 320x200. This is because this special mode is rendered with "baked-in" pixel doubling (we're not doing this for any other mode).

With this fix, raw image & video captures work 100% consistently with our definition of raw captures for all video modes on all emulated adapters 🎉

See the end of this post for a list of games that use the 160x200 Tandy/PCjr mode:

http://nerdlypleasures.blogspot.com/2015/10/advantages-of-160x200-16-color.html

Related issues

#3177

Manual testing

Regression tested raw image & video capture with a couple of VGA and EGA games—all good.

Tested 160x200 16-colour Tandy/PCjr mode with Maniac Mansion v1.

Raw image capture

Raw video capture

Checklist

Please tick the items as you have addressed them. Don't remove items; leave the ones that are not applicable unchecked.

I have:

• followed the project's contributing guidelines and code of conduct.
• performed a self-review of my code.
• commented on the particularly hard-to-understand areas of my code.
• split my work into well-defined, bisectable commits, and I named my commits well.
• applied the appropriate labels (bug, enhancement, refactoring, documentation, etc.)
• checked that all my commits can be built.
• confirmed that my code does not cause performance regressions (e.g., by running the Quake benchmark).
• added unit tests where applicable to prove the correctness of my code and to avoid future regressions.
• made corresponding changes to the documentation or the website according to the documentation guidelines.
• locally verified my website or documentation changes.