Introduce PixelFormat enum #2735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnovak
force-pushed
the
jn/pixel-format-enum
branch
from
04135f8 to
2a66584
Compare
johnnovak
added
plumbing
johnnovak
force-pushed
the
jn/pixel-format-enum
branch
from
2a66584 to
7852cdc
Compare
FeralChild64
reviewed
Aug 6, 2023
FeralChild64
approved these changes
Aug 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so learning from my recent experience with clinically obese PRs 😅, from now on I'm trying to raise multiple smaller ones for refactoring jobs that can be well-separated.
The
bpp(bits per pixel) thing has been bothering me for quite some time now — it really should be an enum, and it should be a pixel format descriptor rather than just a number. Well, now it is 😎Tested with a few games (CGA/EGA/VGA/Tandy), demos, and Return to Zork (to make sure I did not break ReelMagic that had some weird
bpp == 0init hack that luckily wasn't doing anything useful, apparently), plus checked the image & video capture features for regressions. Everything is hunky-dory 😄 (except for #2734, but I broke that one a while ago; that's unrelated to this change).