Skip to content

Add host.docker.internal and host.containers.internal to the dev cert SAN #61265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 22, 2025
Merged

Add host.docker.internal and host.containers.internal to the dev cert SAN #61265

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f192bcf
Add notion of minimum cert version
benjaminpetit Apr 1, 2025
37f340d
Cleaner json output version
benjaminpetit Apr 2, 2025
b19bebd
Revert unecessary change
benjaminpetit Apr 8, 2025
a859ba3
Rename option name and add a test
benjaminpetit Apr 15, 2025
f123d27
Modify ListCertificates_AlwaysReturnsTheCertificate_WithHighestVersio…
benjaminpetit Apr 15, 2025
c5ccb29
Skip on Helix the added test
benjaminpetit Apr 17, 2025
50af593
Merge branch 'main' of https://github.com/dotnet/aspnetcore into tool…
benjaminpetit May 21, 2025
5baecf0
Skip EnsureCreateHttpsCertificate_DoNotOverrideValidOldCertificate on…
benjaminpetit May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip on Helix the added test
  • Loading branch information
@benjaminpetit
benjaminpetit committed Apr 17, 2025
commit c5ccb296a97e4c1fd4d4843a99d23f5618a9bf16
1 change: 1 addition & 0 deletions src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersio
}

[Fact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "All.OSX")]
public void EnsureCreateHttpsCertificate_DoNotOverrideValidOldCertificate()
{
_fixture.CleanupCertificates();
Expand Down
Loading