Skip to content

[release/10.0-preview6] Pack symbols in SharedFx for libraries we redist from runtime #62446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 23, 2025
Merged

[release/10.0-preview6] Pack symbols in SharedFx for libraries we redist from runtime #62446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
242092a
Pack symbols in SharedFx for libraries we redist from runtime
wtgodbe Jun 20, 2025
91638e2
Make it a target
wtgodbe Jun 20, 2025
e0f0d08
Fix PackageRef
wtgodbe Jun 20, 2025
be28aaf
Fix target name
wtgodbe Jun 20, 2025
5973472
Use dependson
wtgodbe Jun 21, 2025
267d747
Just reference it
wtgodbe Jun 21, 2025
602fa5d
Fixup
wtgodbe Jun 21, 2025
efe77d5
Unduplicate
wtgodbe Jun 21, 2025
46ad298
Fix conditions
wtgodbe Jun 23, 2025
f82583e
Exact match
wtgodbe Jun 23, 2025
27ae012
Include transitive .pdb's
wtgodbe Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conditions
  • Loading branch information
@wtgodbe
wtgodbe authored and github-actions committed Jun 23, 2025
commit 46ad29801a79150d6aa3ae7ed4c874bdbe0e1d93
14 changes: 8 additions & 6 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,19 @@
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.pdb" />
</ItemGroup>

<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<Target Name="_AddExtensionsSymbolsToSymbolPack">
<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<!-- Flatten ExternalAspNetCoreAppReference into a property -->
<PropertyGroup>
<FileNameList>@(ExternalAspNetCoreAppReference, ';')</FileNameList>
</PropertyGroup>

<ItemGroup>
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />

<_TransportPdbsWithName Include="@(_TransportPdbs)"
Name="%(Filename)" />

<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
<_SymbolFilesToPackage Include="@(_TransportPdbs)"
Condition="'$(FileNameList)' != '' and $(FileNameList.Contains('%(Filename)'))" />
</ItemGroup>
</Target>

Expand Down
14 changes: 8 additions & 6 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,17 +97,19 @@
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.pdb" />
</ItemGroup>

<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<Target Name="_AddExtensionsSymbolsToSymbolPack">
<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<!-- Flatten ExternalAspNetCoreAppReference into a property -->
<PropertyGroup>
<FileNameList>@(ExternalAspNetCoreAppReference, ';')</FileNameList>
</PropertyGroup>

<ItemGroup>
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />

<_TransportPdbsWithName Include="@(_TransportPdbs)"
Name="%(Filename)" />

<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
<_SymbolFilesToPackage Include="@(_TransportPdbs)"
Condition="'$(FileNameList)' != '' and $(FileNameList.Contains('%(Filename)'))" />
</ItemGroup>
</Target>

Expand Down