Skip to content

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Aug 19, 2025

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WinForms part looks good to me.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that ExtensionMarkerAttribute is present. Thanks

@bartonjs
Copy link
Member

System.Security LGTM

@ericstj ericstj merged commit 87e021b into dotnet:main Sep 5, 2025
3 checks passed
@tannergooding
Copy link
Member

@ericstj, sorry I didn't get to this sooner.

Is it expected that System.Numerics.Tensors isn't showing up here? It's an out of band package, but such packages are likely still interesting to include in the diffs.

@ericstj
Copy link
Member Author

ericstj commented Sep 5, 2025

These diffs only include shared frameworks, not additional OOB packages. It might be interesting to actually generate the diffs as part of the package itself cc @ViktorHofer.

I could see us auto-generating both the API shape and the diff and putting it in the package readme. We might need to choose a single framework to represent though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants