Skip to content

[main] Source code updates from dotnet/dotnet #36242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2025
Merged

[main] Source code updates from dotnet/dotnet #36242

merged 7 commits into from
Jun 16, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 13, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

dotnet-maestro bot added 2 commits June 13, 2025 02:10
@dotnet-maestro
[VMR] Codeflow 20fdc50-e118109
ea41464 
[[ commit created by automation ]]
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 271417
0cac3b5 
Updated Dependencies:
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Text.Json, System.Text.Encodings.Web, System.Formats.Asn1, System.Runtime.Caching (Version 10.0.0-preview.6.25311.102 -> 10.0.0-preview.6.25311.107)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25311.102 -> 10.0.0-beta.25311.107)
@cincuranet
Copy link
Contributor

This is failing with:

Unhandled exception. System.TypeLoadException: Could not resolve type 'Internal.Runtime.Augments.DynamicDelegateAugments' in assembly 'System.Private.CoreLib, Version=10.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.
   at System.Reflection.TypeNameResolver.GetType(String escapedTypeName, ReadOnlySpan`1 nestedTypeNames, TypeName parsedName)
   at System.Reflection.TypeNameResolver.GetTypeHelper(ReadOnlySpan`1 typeName, RuntimeAssembly requestingAssembly, Boolean throwOnError, Boolean requireAssemblyQualifiedName, IntPtr unsafeAccessorMethod)
Aborted (core dumped)

@jkotas
Copy link
Member

jkotas commented Jun 13, 2025

cc @jkoritzinsky @AaronRobinsonMSFT

This was introduced as side-effect of dotnet/runtime#115583

  • We try to inline accessor targeting method that does not exist on a background thread. The exceptions thrown during inlining should be swallowed, but it is not happening for some reason. @AaronRobinsonMSFT Could you please take a look? (It may be a problem in exception handling that JanV needs to look at. It appears to only happen on macOS and Linux.)

  • @jkoritzinsky We should mark the UnsafeAccessors that are targeting methods that are likely not going to exist with NoInline to avoid thrown and swallowed exceptions. It should unblock this PR.

@akoeplinger akoeplinger mentioned this pull request Jun 13, 2025
Merged
@jkoritzinsky jkoritzinsky mentioned this pull request Jun 13, 2025
Merged
dotnet-maestro bot added 3 commits June 14, 2025 02:10
@dotnet-maestro
[VMR] Codeflow 0b17ca4-0b17ca4
15b1964 
[[ commit created by automation ]]
@dotnet-maestro
Merging main into darc-main-617edd15-d7bd-4f40-9fc3-48613e5dfc25
dee81ad
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 271708
34d72bc 
Updated Dependencies:
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Text.Json, System.Text.Encodings.Web, System.Formats.Asn1, System.Runtime.Caching (Version 10.0.0-preview.6.25311.107 -> 10.0.0-preview.6.25313.102)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25311.107 -> 10.0.0-beta.25313.102)
@jkotas jkotas mentioned this pull request Jun 14, 2025
Closed
@jkotas
Copy link
Member

jkotas commented Jun 14, 2025

We try to inline accessor targeting method that does not exist on a background thread. The exceptions thrown during inlining should be swallowed, but it is not happening for some reason.

Opened dotnet/runtime#116676

dotnet-maestro bot added 2 commits June 15, 2025 02:04
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 271805
c2d6456 
Updated Dependencies:
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Text.Json, System.Text.Encodings.Web, System.Formats.Asn1, System.Runtime.Caching (Version 10.0.0-preview.6.25313.102 -> 10.0.0-preview.6.25314.101)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25313.102 -> 10.0.0-beta.25314.101)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 271836
f78142b 
Updated Dependencies:
Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Text.Json, System.Text.Encodings.Web, System.Formats.Asn1, System.Runtime.Caching (Version 10.0.0-preview.6.25314.101 -> 10.0.0-preview.6.25315.102)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25314.101 -> 10.0.0-beta.25315.102)
@dotnet-maestro dotnet-maestro bot merged commit 4dc10d6 into main Jun 16, 2025
12 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-617edd15-d7bd-4f40-9fc3-48613e5dfc25 branch June 16, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@cincuranet cincuranet Awaiting requested review from cincuranet cincuranet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cincuranet @jkotas @AndriySvyryd