Skip to content

Adding the vector constants property extensions that are only supported for certain T #117975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 20, 2025
Merged

Adding the vector constants property extensions that are only supported for certain T #117975

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
89e9b35
Adding the vector constants property extensions that are only support…
tannergooding Jul 23, 2025
25a962f
Use static_cast<int64_t> instead of I64
tannergooding Jul 23, 2025
1f17a81
Ensure mono corelib also suppresses the API compat warnings for exten…
tannergooding Jul 23, 2025
df6a9fa
Update src/libraries/System.Private.CoreLib/src/System/Runtime/Intrin…
tannergooding Jul 23, 2025
1fc18b8
Fixing a couple additional tests
tannergooding Jul 23, 2025
a842d7d
Have the linker preserve the `extension marker method` if the type is…
tannergooding Jul 23, 2025
b47945b
Have TestConstant check for IsNaN rather than a specific bit pattern
tannergooding Jul 23, 2025
e1a3824
Merge remote-tracking branch 'dotnet/main' into fix-117569
tannergooding Aug 3, 2025
2bce8ce
Remove linker workaround for extension members
tannergooding Aug 3, 2025
ea7063d
Update src/tests/JIT/HardwareIntrinsics/X86/Regression/GitHub_17073/G…
tannergooding Aug 3, 2025
f8bdb3c
Merge branch 'main' into fix-117569
tannergooding Aug 7, 2025
b86b248
Merge branch 'main' into fix-117569
tannergooding Aug 12, 2025
4535575
Merge branch 'main' into fix-117569
tannergooding Aug 13, 2025
4fd8b16
Merge branch 'main' into fix-117569
tannergooding Aug 19, 2025
2400bab
Don't override the toolset compiler for runtime tests
tannergooding Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 94 additions & 0 deletions src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Numerics.Vector.&lt;&gt;E__0`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Numerics.Vector.&lt;&gt;E__1`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Numerics.Vector.&lt;&gt;E__2`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector128.&lt;&gt;E__0`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector128.&lt;&gt;E__1`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector128.&lt;&gt;E__2`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector256.&lt;&gt;E__0`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector256.&lt;&gt;E__1`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector256.&lt;&gt;E__2`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector512.&lt;&gt;E__0`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector512.&lt;&gt;E__1`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector512.&lt;&gt;E__2`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector64.&lt;&gt;E__0`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector64.&lt;&gt;E__1`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.Intrinsics.Vector64.&lt;&gt;E__2`1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
</Suppressions>
4 changes: 4 additions & 0 deletions src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
<FeatureSingleThread Condition="'$(TargetsBrowser)' == 'true'">true</FeatureSingleThread>
</PropertyGroup>

<ItemGroup>
<ApiCompatSuppressionFile Include="$(MSBuildProjectDirectory)\CompatibilitySuppressions.xml" />
</ItemGroup>

<ItemGroup>
<ILLinkSubstitutionsXmls Include="$(ILLinkDirectory)ILLink.Substitutions.xml" />
</ItemGroup>
Expand Down
36 changes: 36 additions & 0 deletions src/coreclr/jit/fgbasic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,18 +1479,54 @@ void Compiler::fgFindJumpTargets(const BYTE* codeAddr, IL_OFFSET codeSize, Fixed
#if defined(FEATURE_HW_INTRINSICS)
#if defined(TARGET_ARM64)
case NI_Vector64_get_AllBitsSet:
case NI_Vector64_get_E:
case NI_Vector64_get_Epsilon:
case NI_Vector64_get_NaN:
case NI_Vector64_get_NegativeInfinity:
case NI_Vector64_get_NegativeOne:
case NI_Vector64_get_NegativeZero:
case NI_Vector64_get_One:
case NI_Vector64_get_Pi:
case NI_Vector64_get_PositiveInfinity:
case NI_Vector64_get_Tau:
case NI_Vector64_get_Zero:
#endif // TARGET_ARM64
case NI_Vector128_get_AllBitsSet:
case NI_Vector128_get_E:
case NI_Vector128_get_Epsilon:
case NI_Vector128_get_NaN:
case NI_Vector128_get_NegativeInfinity:
case NI_Vector128_get_NegativeOne:
case NI_Vector128_get_NegativeZero:
case NI_Vector128_get_One:
case NI_Vector128_get_Pi:
case NI_Vector128_get_PositiveInfinity:
case NI_Vector128_get_Tau:
case NI_Vector128_get_Zero:
#if defined(TARGET_XARCH)
case NI_Vector256_get_AllBitsSet:
case NI_Vector256_get_E:
case NI_Vector256_get_Epsilon:
case NI_Vector256_get_NaN:
case NI_Vector256_get_NegativeInfinity:
case NI_Vector256_get_NegativeOne:
case NI_Vector256_get_NegativeZero:
case NI_Vector256_get_One:
case NI_Vector256_get_Pi:
case NI_Vector256_get_PositiveInfinity:
case NI_Vector256_get_Tau:
case NI_Vector256_get_Zero:
case NI_Vector512_get_AllBitsSet:
case NI_Vector512_get_E:
case NI_Vector512_get_Epsilon:
case NI_Vector512_get_NaN:
case NI_Vector512_get_NegativeInfinity:
case NI_Vector512_get_NegativeOne:
case NI_Vector512_get_NegativeZero:
case NI_Vector512_get_One:
case NI_Vector512_get_Pi:
case NI_Vector512_get_PositiveInfinity:
case NI_Vector512_get_Tau:
case NI_Vector512_get_Zero:
#endif // TARGET_XARCH
#endif // FEATURE_HW_INTRINSICS
Expand Down
156 changes: 156 additions & 0 deletions src/coreclr/jit/hwintrinsicarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,6 +1398,40 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,
break;
}

case NI_Vector64_get_E:
case NI_Vector128_get_E:
{
assert(sig->numArgs == 0);

if (varTypeIsFloating(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, 2.718281828459045);
retNode = vecCns;
}
break;
}

case NI_Vector64_get_Epsilon:
case NI_Vector128_get_Epsilon:
{
assert(sig->numArgs == 0);

if (simdBaseType == TYP_FLOAT)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_INT, I64(0x00000001));
retNode = vecCns;
}
else if (simdBaseType == TYP_DOUBLE)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_LONG, I64(0x0000000000000001));
retNode = vecCns;
}
break;
}

case NI_Vector64_get_Indices:
case NI_Vector128_get_Indices:
{
Expand All @@ -1406,6 +1440,80 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,
break;
}

case NI_Vector64_get_NaN:
case NI_Vector128_get_NaN:
{
assert(sig->numArgs == 0);

if (simdBaseType == TYP_FLOAT)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_INT, I64(0x7FC00000));
retNode = vecCns;
}
else if (simdBaseType == TYP_DOUBLE)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_LONG, I64(0x7FF8000000000000));
retNode = vecCns;
}
break;
}

case NI_Vector64_get_NegativeInfinity:
case NI_Vector128_get_NegativeInfinity:
{
assert(sig->numArgs == 0);

if (simdBaseType == TYP_FLOAT)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_INT, I64(0xFF800000));
retNode = vecCns;
}
else if (simdBaseType == TYP_DOUBLE)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_LONG, I64(0xFFF0000000000000));
retNode = vecCns;
}
break;
}

case NI_Vector64_get_NegativeOne:
case NI_Vector128_get_NegativeOne:
{
assert(sig->numArgs == 0);

if (varTypeIsFloating(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, -1.0);
retNode = vecCns;
}
else if (varTypeIsSigned(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, I64(-1));
retNode = vecCns;
}
break;
}

case NI_Vector64_get_NegativeZero:
case NI_Vector128_get_NegativeZero:
{
assert(sig->numArgs == 0);

if (varTypeIsFloating(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, -0.0);
retNode = vecCns;
}
break;
}

case NI_Vector64_get_One:
case NI_Vector128_get_One:
{
Expand All @@ -1414,6 +1522,54 @@ GenTree* Compiler::impSpecialIntrinsic(NamedIntrinsic intrinsic,
break;
}

case NI_Vector64_get_Pi:
case NI_Vector128_get_Pi:
{
assert(sig->numArgs == 0);

if (varTypeIsFloating(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, 3.141592653589793);
retNode = vecCns;
}
break;
}

case NI_Vector64_get_PositiveInfinity:
case NI_Vector128_get_PositiveInfinity:
{
assert(sig->numArgs == 0);

if (simdBaseType == TYP_FLOAT)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_INT, I64(0x7F800000));
retNode = vecCns;
}
else if (simdBaseType == TYP_DOUBLE)
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(TYP_LONG, I64(0x7FF0000000000000));
retNode = vecCns;
}
break;
}

case NI_Vector64_get_Tau:
case NI_Vector128_get_Tau:
{
assert(sig->numArgs == 0);

if (varTypeIsFloating(simdBaseType))
{
GenTreeVecCon* vecCns = gtNewVconNode(retType);
vecCns->EvaluateBroadcastInPlace(simdBaseType, 6.283185307179586);
retNode = vecCns;
}
break;
}

case NI_Vector64_get_Zero:
case NI_Vector128_get_Zero:
{
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/hwintrinsiccodegenxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,7 +2346,7 @@ void CodeGen::genBaseIntrinsic(GenTreeHWIntrinsic* node, insOpts instOptions)
//
// Vector128<int> overflowMask =
// Vector128.Equals(op1, Vector128.Create(int.MinValue)
// & Vector128.Equals(op2, Vector128.Create(-1));
// & Vector128.Equals(op2, Vector128<int>.NegativeOne);
// if (!Vector128.EqualsAll(overflowMask, Vector128<int>.Zero))
// {
// throw new OverflowException();
Expand Down
Loading
Loading